static-web-apps-cli icon indicating copy to clipboard operation
static-web-apps-cli copied to clipboard

Cannot deploy if app dist folder or function project is in project root

Open sinedied opened this issue 1 year ago • 0 comments

Before filing this issue, please ensure you're using the latest CLI by running swa --version and comparing to the latest version on npm.

Are you accessing the CLI from the default port :4280 ?

  • [ ] No, I am using a different port number (--port) and accessing the CLI from that port
  • [x] Yes, I am accessing the CLI from port :4280

Make sure you are accessing the URL printed in the console when running swa start!

ℹ️ NOTE: Make sure to enable debug logs when running any swa commands using --verbose=silly

Describe the bug If I have a project with a static website at the root of the repo, and a function contained in an /api subfolder, I cannot deploy the function and get this error:

image

Note that the same error occur is the website is in a subfolder, and the API package.json at the root of the repo (maybe a more common scenario), see https://github.com/sinedied/swa-functions-root-bug/tree/api-root

To Reproduce

  1. Git clone this repo: https://github.com/sinedied/swa-functions-root-bug/
  2. Run swa deploy

Expected behavior No errors.

Desktop (please complete the following information):

  • OS: MacOS
  • Version 14.4

Additional context It seems that the problem is due to the StaticSiteClient creating zip file of the artifacts in the current folder. Using a different temp folder might solve the issue.

sinedied avatar Mar 28 '24 17:03 sinedied