static-web-apps-cli icon indicating copy to clipboard operation
static-web-apps-cli copied to clipboard

Colon in `swa-cli.config.json` `configuration.run` value causing field to not be read

Open jag43 opened this issue 2 years ago • 1 comments

Before filing this issue, please ensure you're using the latest CLI by running swa --version and comparing to the latest version on npm.

swa -v
1.1.6

Are you accessing the CLI from the default port :4280 ?

  • [ ] ~No, I am using a different port number (--port) and accessing the CLI from that port~
  • [ ] ~Yes, I am accessing the CLI from port :4280~
  • [x] N/A

Make sure you are accessing the URL printed in the console when running swa start!

ℹ️ NOTE: Make sure to enable debug logs when running any swa commands using --verbose=silly

Describe the bug

configuration.run value does not seem to be picked up correctly if the value contains a colon (:)

To Reproduce

I can see this in options.run with --print-config but it doesn't seem to get passed on to SWA_CLI_STARTUP_COMMAND when checking -V=silly:

I set a run value in swa-cli-config.json like this:

"run": "npm run dev:admin",
- SWA_CLI_STARTUP_COMMAND:

If I remove the colon

"run": "npm run dev",
- SWA_CLI_STARTUP_COMMAND: npm run dev

Expected behavior

I expect the value with the colon to be read om correctly

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10
  • Version 22H2

Additional context I made a minimal repro here https://github.com/jag43/swa-repro You can see the different behaviour with

swa start --config-name swa-repro-colon --print-config -V=silly

and

swa start --config-name swa-repro-no-colon --print-config -V=silly

jag43 avatar Nov 13 '23 18:11 jag43

Thanks for your feedback. I can reproduce the issue and will fix it in the next release.

cjk7989 avatar Nov 14 '23 12:11 cjk7989