static-web-apps-cli icon indicating copy to clipboard operation
static-web-apps-cli copied to clipboard

Published 20 hours ago • verified publisher icon Azure

feat: Add new flags for Function runtime and Function version

Open sgollapudi77 opened this issue 3 years ago • 2 comments
trafficstars

Closes #519

sgollapudi77 avatar Sep 14 '22 17:09 sgollapudi77

@sinedied @manekinekko please check now, pushed new changes.

sgollapudi77 avatar Oct 06 '22 14:10 sgollapudi77

@sgollapudi77 - Please get approval from @sinedied / @manekinekko before merging the PR.

sulabh-msft avatar Oct 06 '22 15:10 sulabh-msft

@sinedied / @manekinekko
Can you please review the PR? We want to get changes in sooner.

cc: @sgollapudi77

sulabh-msft avatar Nov 08 '22 12:11 sulabh-msft

@manekinekko , @sinedied if you get some time, please review this PR.

sgollapudi77 avatar Dec 22 '22 06:12 sgollapudi77

@sulabh-msft @sgollapudi77 I don't want to block this PR any further, but some refactoring should be done in a further PR to have a single source of truth for the default runtime and versions, as they're defined in:

  • src/core/constants.ts
  • src/config.ts
  • src/core/frameworks/frameworks.ts
  • src/core/functions-versions.ts

I would suggest choosing one place, src/core/functions-versions.ts being a good candidate (as once the logger is removed from there it has no dependencies), and all other referencing runtimes/versions from it. Bumping into circular dependencies is a good indication that something's not right IMHO.

Thanks Yohan, we will merge this PR into SwaCli after the Hawaii changes are released. We don't want to have any regressions before the public preview of the Hawaii. And we will follow up in the next iterations of the PR to modify the items you suggested,

sgollapudi77 avatar Mar 02 '23 04:03 sgollapudi77