static-web-apps-cli icon indicating copy to clipboard operation
static-web-apps-cli copied to clipboard

feat: add api runtime flags

Open sgollapudi77 opened this issue 3 years ago • 6 comments
trafficstars

sgollapudi77 avatar May 04 '22 10:05 sgollapudi77

Is this to support the use case where the api runtime is not set in staticwebapp.config.json?

sinedied avatar May 04 '22 14:05 sinedied

Is this to support the use case where the api runtime is not set in staticwebapp.config.json?

Yes, Yohan. But for this to work the code in the StaticSiteclient needs to be merged.

sgollapudi77 avatar May 05 '22 16:05 sgollapudi77

Could you also update the config schema in schema/?

Done. Please check now.

sgollapudi77 avatar May 05 '22 16:05 sgollapudi77

Thanks! Could you rebase your branch with latest changes from ga so I can merge it?

Done

sgollapudi77 avatar May 06 '22 05:05 sgollapudi77

Closes #519

sgollapudi77 avatar Jun 10 '22 10:06 sgollapudi77

@sgollapudi77 Looks like there are few merge conflicts.. Can you please pull latest code

sulabh-msft avatar Jun 22 '22 17:06 sulabh-msft

@sgollapudi77 thank you for adding these changes. Could you also update the docs to reflect these changes?

manekinekko avatar Aug 31 '22 14:08 manekinekko

Closing this PR and re-opening new one against main branch.

sgollapudi77 avatar Sep 14 '22 13:09 sgollapudi77