secrets-store-csi-driver-provider-azure icon indicating copy to clipboard operation
secrets-store-csi-driver-provider-azure copied to clipboard

Provide the helm chart through mcr.microsoft.com

Open stan-sz opened this issue 3 years ago • 5 comments

Describe the solution you'd like mcr.microsoft.com is capable of storing helm charts. Since all images referenced in the helm chart are from mcr.microsoft.com, it would be coherent to have the chart be pullable from the same source.

stan-sz avatar Feb 18 '22 13:02 stan-sz

@aramase - what's your take on that? It's is related to #784

stan-sz avatar Apr 13 '22 08:04 stan-sz

@aramase - what's your take on that? It's is related to https://github.com/Azure/secrets-store-csi-driver-provider-azure/pull/784

@stan-sz There is currently no plan to move the helm charts to mcr. The common pattern we have been following across all OSS projects (including CNCF ones) have been to host the helm charts in the main branch or gh-pages (the latter being more commonly used now).

The images are hosted in mcr but in case of helm charts AFAIK there are certain limitations on helm version for hosting in mcr. Do you have any specific requirement for pulling charts from mcr.microsoft.com and not ones hosted in github?

aramase avatar Apr 13 '22 16:04 aramase

Indeed, helm 3.7+ is capable of pulling a chart from a container registry. Can you push the chart to both the gh-pages and mcr.microsoft.com?

stan-sz avatar Apr 14 '22 09:04 stan-sz

@stan-sz can you elaborate more on your requirements for chart to be in MCR please?

sozercan avatar May 12 '22 19:05 sozercan

It's not a strong requirement yet, it is a simplification to host the chart with images in the same ACR. A non-functional requirement is that we have seen rate limiting when pulling binaries from github in our build pipelines. Hosting the chart in ACR raises the limit.

stan-sz avatar May 17 '22 07:05 stan-sz

Closing this issue as it's currently not planned. Feel free to open a new issue if you have any questions.

aramase avatar Nov 10 '22 23:11 aramase