login icon indicating copy to clipboard operation
login copied to clipboard

Release v2.2.0 changed the order of the post step

Open branchgrove opened this issue 5 months ago • 6 comments

With the release of v2.2.0 the post step has changed when it runs. Previously it was usually the last step in a job but now it is running earlier than expected. This has broken some of my own post steps which expects the job to be logged in in order to cleanup resources in Azure.

I think it's due to the pre-step being removed by default which changed when the post-step runs.

v2.1.1

pre azure/login
step-1
azure/login
step-2
step-3
step-4
post step-1
post azure/login

v2.2.0

step-1
azure/login
step-2
step-3
step-4
post azure/login
post step-1

I understand that it is not that great that the post step-1 assumes that the job is logged in however the behaviour was unfortunately relied upon. Since we typically pin to @v2 it broke out of the blue and I think this should have been released as 3.0.0.

branchgrove avatar Sep 18 '24 11:09 branchgrove