kaito

kaito copied to clipboard

chore: refactor unnecessary anonymous function

11

**Reason for Change**: chore: refactor unnecessary anonymous function **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: **Notes for Reviewers**:

cvvz

chore: reuse existing logging package provided by controller runtime in main function

3

Chores: reuse existing logging package provided by controller runtime in main function **Reason for Change**: Remove unnecessary klog related flush calls. **Requirements** - [ ] added unit tests and e2e...

MartinForReal

chore: bump vllm from 0.8.2 to 0.8.4 in /presets/workspace/dependencies

6

Bumps [vllm](https://github.com/vllm-project/vllm) from 0.8.2 to 0.8.4. Release notes Sourced from vllm's releases. v0.8.4 This release contains 180 commits from 84 contribturos (25 new contribtors!). Highlights This release includes important accuracy...

dependabot[bot]

Use `r.Record.Eventf` instead of `updateStatusConditionIfNotMatch` to record important event/step in sync loop

1

**Is your feature request related to a problem? Please describe.** Currently we use `updateStatusConditionIfNotMatch` to update the condition of workspace/ragEngine. However, it is used too frequently, almost like a logger...

cvvz

Should not rely on `controllerRevision` to decide whether to perform create/update

1

**Is your feature request related to a problem? Please describe.** `controllerRevision` is used to implement roll back for resources like statefulset/deployment. Per my understanding, it is used here just to...

cvvz

Add node informer to cache the node resource and avoid request directly to apiserver

1

This issue is to track https://github.com/kaito-project/kaito/pull/1052. We should avoid get/list node from apiserver directly in operator. However, since add informer for all nodes will cause huge memory usage when the...

cvvz

Integrate ragEngineController with workspaceController as an single controller

1

**Is your feature request related to a problem? Please describe.** There is no need to create a standalone `ragEngineController`. We can simply create `ragEngineReconciler` and `SetupWithManager` [in workspace controller](https://github.com/kaito-project/kaito/blob/main/cmd/workspace/main.go#L118-L128) ....

cvvz

Should we refactor the webhook implementation by using kubebuilder webhook scaffolding?

1

**Is your feature request related to a problem? Please describe.** Currently, the webhook is implemented by knative library. I suggest to refactor by using [kubebuilder webhook scaffolding](https://book.kubebuilder.io/cronjob-tutorial/webhook-implementation), which is the...

cvvz

Add convertion webhook for v1alpha1 and v1beta1 objects

1

**Is your feature request related to a problem? Please describe.** Add convertion webhook for v1alpha1 and v1beta1 objects We need to define the default version of crd and implement convert...

MartinForReal

chore: enable https for metrics port

4

**Reason for Change**: chore: enable https for metrics port **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: **Notes for Reviewers**:

MartinForReal