kaito icon indicating copy to clipboard operation
kaito copied to clipboard

fix: Keep Docker Sidecar Alive for Data Retrieval

Open ishaansehgal99 opened this issue 1 year ago • 1 comments

Reason for Change: Keep the docker sidecar container alive so incase ACR push fails we can still exec into the container to retrieve completed tuning job files in the /mnt/results folder.

ishaansehgal99 avatar Aug 08 '24 22:08 ishaansehgal99

Codecov Report

Attention: Patch coverage is 11.59420% with 61 lines in your changes missing coverage. Please review.

Project coverage is 56.54%. Comparing base (ed546f0) to head (46b0ed1). Report is 37 commits behind head on main.

Files Patch % Lines
pkg/tuning/preset-tuning.go 0.00% 34 Missing :warning:
pkg/utils/common-preset.go 0.00% 13 Missing :warning:
pkg/controllers/workspace_controller.go 0.00% 7 Missing :warning:
pkg/utils/common.go 0.00% 7 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   61.10%   56.54%   -4.57%     
==========================================
  Files          29       30       +1     
  Lines        2602     2966     +364     
==========================================
+ Hits         1590     1677      +87     
- Misses        921     1191     +270     
- Partials       91       98       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 09 '24 04:08 codecov[bot]