k8s-deploy
k8s-deploy copied to clipboard
Bug: pod is not restarted if docker tag name is not changed
What happened?
if the manifest file is deployment
, i expected restarting pod.
but, pod is not restarted because owner
is wrong.
it is related with this code block.
- https://github.com/Azure/k8s-deploy/blob/d565a17533bbfa9b191d71bf9a8e3b8e613cce29/src/types/kubectl.ts#L83
if (result?.stdout) {
const stdout = result.stdout.split('\n')
core.debug('stdout from getNewReplicaSet is ' + JSON.stringify(stdout))
stdout.forEach((line: string) => {
const newreplicaset = 'newreplicaset'
if (line && line.toLowerCase().indexOf(newreplicaset) > -1) {
core.debug(
`found string of interest for replicaset, line is ${line}`
)
core.debug(
`substring is ${line.substring(newreplicaset.length).trim()}`
)
newReplicaSet = line
.substring(newreplicaset.length)
.trim()
.split(' ')[0]
}
})
}
here is the result of kubectl describe deployment
.
...
NewReplicaSet: xxx-deployment-7675bf5865 (1/1 replicas created)
...
and this line will be converted to :
.
i think const newreplicaset = 'newreplicaset'
should be changed to const newreplicaset = 'newreplicaset:'
.
Version
- [X] I am using the latest version
Runner
self hosted
Relevant log output
##[debug]found string of interest for replicaset, line is Progressing True NewReplicaSetAvailable
##[debug]substring is True NewReplicaSetAvailable
##[debug]found string of interest for replicaset, line is NewReplicaSet: xxx-deployment-77546558b9 (1/1 replicas created)
##[debug]substring is : xxx-deployment-77546558b9 (1/1 replicas created)