k8s-deploy icon indicating copy to clipboard operation
k8s-deploy copied to clipboard

Bug: private cluster action success on error

Open y-luis-rojo opened this issue 2 years ago • 3 comments

What happened?

The execution of Azure/k8s-deploy@v4 action shows an error, nothing is deployed and still the result of the job is a success: image

I would expect any execution error result in a job failure.

Version

  • [X] I am using the latest version

Runner

self-hosted Ubuntu 20.04

Relevant log output

Sorry, don't know how to run in debug mode, please share how to do it, if needed.

y-luis-rojo avatar Oct 11 '22 13:10 y-luis-rojo

Hello @y-luis-rojo! Thanks for the issue. Could you post what your workflow looks like please?

OliverMKing avatar Oct 12 '22 19:10 OliverMKing

Sure:

  deploy:
    runs-on: [ atc-ubuntu-20.04 ]
    steps:
      - uses: actions/checkout@v3
      - uses: azure/setup-kubectl@v3
        id: install
      - uses: azure/login@v1
        with:
          creds: ${{ secrets.AZURE_CREDENTIALS }}
      - uses: azure/aks-set-context@v3
        with:
          cluster-name: ${{ env.CLUSTER_NAME }}
          resource-group: ${{ env.RESOURCE_GROUP }}
      - run: az acr login -n ${{ env.CONTAINER_REGISTRY }}
      - uses: Azure/k8s-deploy@v4
        with:
          namespace: ${{ env.NAMESPACE }}
          manifests: |
            k8s/deployment.yaml
          private-cluster: true
          resource-group: ${{ env.RESOURCE_GROUP }}
          name: ${{ env.CLUSTER_NAME }}

y-luis-rojo avatar Oct 13 '22 08:10 y-luis-rojo

I'm pretty positive this is a private-cluster only bug. I'm investigating the issue now. Thanks!

OliverMKing avatar Oct 14 '22 16:10 OliverMKing

Hello! The newest 4.6 (and 4) releases should fix this. Thanks!

OliverMKing avatar Oct 31 '22 17:10 OliverMKing