k8s-deploy icon indicating copy to clipboard operation
k8s-deploy copied to clipboard

Unnecessary `docker pull` being triggered

Open richardsimko opened this issue 2 years ago • 7 comments

I have a workflow that's deploying some manifests which don't contain any images and yet the workflow is still triggering a docker pull which fails with the following error:

Deploying manifests
Warning: Deployment strategy is not recognized.
/usr/local/bin/kubectl apply -f /tmp/kafka.yml,/tmp/monitoring.yml --insecure-skip-tls-verify --namespace metrics
prometheusrule.monitoring.coreos.com/staging.kafka-to-bq-lag created
prometheusrule.monitoring.coreos.com/data-science-monitoring.rules created
Checking manifest stability
Printing ingresses
Annotating resources
/usr/bin/docker pull 
invalid reference format
Warning: Failed to get dockerfile path for image : Error: The process '/usr/bin/docker' failed with exit code 1 

richardsimko avatar Jul 04 '22 13:07 richardsimko

As a temporary workaround you can use the

pull-images: false

option

OliverMKing avatar Jul 06 '22 14:07 OliverMKing

Thanks!

richardsimko avatar Jul 07 '22 09:07 richardsimko

This issue is idle because it has been open for 14 days with no activity.

github-actions[bot] avatar Jul 21 '22 12:07 github-actions[bot]

Not idle, still waiting for a fix but the workaround works for now

richardsimko avatar Jul 21 '22 13:07 richardsimko

@richardsimko can you post the inputs you are supplying to k8s-deploy? And which version of deploy this is

OliverMKing avatar Jul 27 '22 17:07 OliverMKing

Sure, here it is:

      - name: Deploy alerts
        uses: azure/k8s-deploy@v4
        with:
          manifests: |
            k8s/production/alerts

The alerts themselves contain only PrometheusRule definitions and no services.

richardsimko avatar Jul 28 '22 07:07 richardsimko

This issue is idle because it has been open for 14 days with no activity.

github-actions[bot] avatar Aug 11 '22 09:08 github-actions[bot]

related issue: #164

kireerik avatar Aug 31 '22 13:08 kireerik

Using pull-images: false solves the issue

richardsimko avatar Aug 31 '22 15:08 richardsimko