iotedge-lorawan-starterkit
iotedge-lorawan-starterkit copied to clipboard
Implement IoT Hub Station twin
PR for implementing Station twin in IoT Hub implementation
What is being addressed
Implementing the station twin, helps me to decouple LoRa management facade from the IoT Hub device twin.
How is this addressed
- Create the IStationTwin interface
- Implement new method in Registry manager to retrieve station by its StationEui
- Adapt unit test
Codecov Report
Merging #1822 (8850e5e) into dev (077f7fb) will decrease coverage by
0.00%
. The diff coverage is90.90%
.
@@ Coverage Diff @@
## dev #1822 +/- ##
==========================================
- Coverage 87.41% 87.40% -0.01%
==========================================
Files 251 252 +1
Lines 9573 9575 +2
==========================================
+ Hits 8368 8369 +1
- Misses 1205 1206 +1
Impacted Files | Coverage Δ | |
---|---|---|
...RaEngine/LoraKeysManagerFacade/EdgeDeviceGetter.cs | 96.42% <ø> (ø) |
|
...dule/LoraTools/IoTHubImpl/IoTHubRegistryManager.cs | 96.77% <0.00%> (-0.79%) |
:arrow_down: |
...Wan.NetworkServerDiscovery/TagBasedLnsDiscovery.cs | 86.04% <100.00%> (-0.32%) |
:arrow_down: |
...SrvModule/LoraTools/IoTHubImpl/IoTHubDeviceTwin.cs | 92.30% <100.00%> (ø) |
|
...rvModule/LoraTools/IoTHubImpl/IoTHubStationTwin.cs | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@Mandur, @danigian can we merge it ?
Tests are ok (still flakiness in multiconcentrators, CUPS and discovery that need to be investigated)