[V1] New Release with updated submodules?

[villepalo]

Description of the issue:

Do you have any plans for the next V1 release? Current version is not usable at all if one uses AMQP or MQTT and internet connection is not stable enough. AMQP leaks memory (#409) and mqtt segfaults after connection break (#520 ) . Both of these bugs are fixed in the latest iot-sdk-c library.

[aribeironovaes]

Hi @villepalo ,

We are working on that, however we don't have a date on when we are going to release V1 again. It's on our plan to switch to the Device SDK LTS as well. Are you able to clone and update the version of the SDK yourself to be unblocked?

Let us know, We will let you know once we release,

Angelo Ribeiro.

[villepalo]

I have tried to update submodules myself but for some reason iot-edge build system is not compatible with newer submodules:

-- Configuring done -- Generating done -- Build files have been written to: /home/user/workspace/user/iot-edge/v1/deps/nanomsg/build -- Installing nanomsg. Please wait... -- NANOMSG LIBRARIES: nanomsg -- NANOMSG CFLAGS: -- NANOMSG LOCATION: /home/user/workspace/user/iot-edge/v1/install-deps/lib/x86_64-linux-gnu/libnanomsg.so -- checking for one of the modules 'uuid' -- Building uamqp... -- The C compiler identification is GNU 4.8.4 -- The CXX compiler identification is GNU 4.8.4 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Looking for include file stdint.h -- Looking for include file stdint.h - found -- Looking for include file stdbool.h -- Looking for include file stdbool.h - found -- Looking for x86_64 -- Looking for x86_64 - found -- target architecture: x86_64 -- Performing Test CXX_FLAG_CXX11 -- Performing Test CXX_FLAG_CXX11 - Success -- Configuring done -- Generating done -- Build files have been written to: /home/user/workspace/user/iot-edge/v1/deps/uamqp/build -- Installing uamqp. Please wait... -- Building umqtt... -- The C compiler identification is GNU 4.8.4 -- The CXX compiler identification is GNU 4.8.4 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Looking for include file stdint.h -- Looking for include file stdint.h - found -- Looking for include file stdbool.h -- Looking for include file stdbool.h - found -- Looking for x86_64 -- Looking for x86_64 - found -- target architecture: x86_64 -- Performing Test CXX_FLAG_CXX11 -- Performing Test CXX_FLAG_CXX11 - Success -- Configuring done -- Generating done -- Build files have been written to: /home/user/workspace/user/iot-edge/v1/deps/umqtt/build -- Installing umqtt. Please wait... -- Building azure_iot_sdks... -- The C compiler identification is GNU 4.8.4 -- The CXX compiler identification is GNU 4.8.4 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- IoT Client SDK Version = 1.2.4 -- Provisioning client OFF -- Looking for x86_64 -- Looking for x86_64 - found -- iothub architecture: x86_64 CMake Error at iothub_client/CMakeLists.txt:437 (install): install TARGETS given target "uamqp" which does not exist in this directory.

-- Configuring incomplete, errors occurred! See also "/home/user/workspace/user/iot-edge/v1/deps/iot-sdk-c/build/CMakeFiles/CMakeOutput.log". CMake Error at gatewayFunctions.cmake:159 (message): Error running cmake for azure_iot_sdks: 1 Call Stack (most recent call first): modules/dependencies.cmake:39 (findAndInstall) modules/CMakeLists.txt:6 (include)

-- Configuring incomplete, errors occurred! See also "/home/user/workspace/user/iot-edge/v1/build/CMakeFiles/CMakeOutput.log".

[aribeironovaes]

Thanks for trying @villepalo ,

@darobs , Do you have an idea how he can fix it?

[darobs]

I guess it's time to do the submodule dance. :)

I'll see if I can get the LTS branch of the C SDK updated into a branch and push it.

[villepalo]

Any news on this issue?

[darobs]

Thank you for the reminder. I got slowed down by some build issue and then got busy with V2 work. I put this back on my list.

[darobs]

Hello everyone, I ran into some problems with the Jan, 2018 LTS build. I'm updating the submodules to current master in anticipation of the next LTS release, which should be soon. I did still have to make a PR against the c-shared submodules to allow a build.

[villepalo]

There is new lts_10_2018 (https://github.com/Azure/azure-iot-sdk-c/commits/lts_10_2018) branch in iot-sdk-c. Could we update submodules now?

[villepalo]

Using lst_10_2018 iot-sdk-c rebuilding deps fails:

-- Configuring done -- Generating done -- Build files have been written to: workspace/iot-edge/v1/deps/nanomsg/build -- Installing nanomsg. Please wait... -- NANOMSG LIBRARIES: nanomsg -- NANOMSG CFLAGS: -- NANOMSG LOCATION: /workspace/iot-edge/v1/install-deps/lib/x86_64-linux-gnu/libnanomsg.so -- checking for one of the modules 'uuid' -- Building uamqp... -- The C compiler identification is GNU 4.8.4 -- The CXX compiler identification is GNU 4.8.4 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done CMake Error at CMakeLists.txt:52 (include): include could not find load file:

deps/c-utility//configs/azure_iot_build_rules.cmake

CMake Error at CMakeLists.txt:54 (set_platform_files): set_platform_files Function invoked with incorrect arguments for function named: set_platform_files

CMake Error at CMakeLists.txt:224 (setTargetBuildProperties): Unknown CMake command "setTargetBuildProperties".

-- Configuring incomplete, errors occurred! See also "workspace/iot-edge/v1/deps/uamqp/build/CMakeFiles/CMakeOutput.log". CMake Error at gatewayFunctions.cmake:159 (message): Error running cmake for uamqp: 1 Call Stack (most recent call first): modules/dependencies.cmake:9 (findAndInstall) modules/CMakeLists.txt:6 (include)

Also running unit test fails

-- Configuring done -- Generating done -- Build files have been written to: workspace/iot-edge/v1/deps/nanomsg/build -- Installing nanomsg. Please wait... -- NANOMSG LIBRARIES: nanomsg -- NANOMSG CFLAGS: -- NANOMSG LOCATION: workspace/iot-edge/v1/install-deps/lib/x86_64-linux-gnu/libnanomsg.so -- checking for one of the modules 'uuid' -- checking for one of the modules 'gio-unix-2.0' CMake Error at install-deps/cmake/azure_c_shared_utilityFunctions.cmake:257 (linux_unittests_add_exe): A logical block opening on the line

workspace/iot-edge/v1/install-deps/cmake/azure_c_shared_utilityFunctions.cmake:153 (if)

is not closed. Call Stack (most recent call first): modules/ble/tests/bleio_seq_ut/CMakeLists.txt:69 (build_test_artifacts)

CMake Error at install-deps/cmake/azure_c_shared_utilityFunctions.cmake:257 (linux_unittests_add_exe): A logical block opening on the line

workspace/iot-edge/v1/install-deps/cmake/azure_c_shared_utilityFunctions.cmake:153 (if)

is not closed. Call Stack (most recent call first): modules/ble/tests/gatt_io_ut/CMakeLists.txt:69 (build_test_artifacts)

CMake Error at install-deps/cmake/azure_c_shared_utilityFunctions.cmake:257 (linux_unittests_add_exe): A logical block opening on the line

workspace/iot-edge/v1/install-deps/cmake/azure_c_shared_utilityFunctions.cmake:153 (if)

is not closed. Call Stack (most recent call first): modules/ble/tests/gio_async_seq_ut/CMakeLists.txt:33 (build_test_artifacts)

[villepalo]

Hello everyone, I ran into some problems with the Jan, 2018 LTS build. I'm updating the submodules to current master in anticipation of the next LTS release, which should be soon. I did still have to make a PR against the c-shared submodules to allow a build.

@darobs Any news on this? Is this new LTS going to be pulled into iot-edge-v1?

[villepalo]

Solved the problem by cherry-picking those memory leaks and segfault fixes to submodule forks and iot-edge fork. Now the system seems to work ok.