draft-classic icon indicating copy to clipboard operation
draft-classic copied to clipboard

Feature Request: Add ability to specify array of helm chart values files

Open dm3ch opened this issue 7 years ago • 7 comments

It would be great to have ability to specify array of values files for helm chart in draft toml config.

For example it could be needed for working on application in public git repository and keep values.yaml with not sensitive params and have second values files with sensitive params ignored by git. So people could see in repo properties required by chart but not see sensitive data

dm3ch avatar Aug 11 '18 20:08 dm3ch

Related: #818

max-baz avatar Aug 28 '18 08:08 max-baz

So I've been looking at https://github.com/Azure/draft/issues/818 and this ticket, since I think it'd be a cool thing to contribute.

The place where Helm merges values files is in cmd/helm/install.go, and I've been looking into how Draft loads values files, but I'll try start working on a PR sometime this week.

zoidyzoidzoid avatar Oct 02 '18 13:10 zoidyzoidzoid

Hey, @zoidbergwill! Let us know if you have any questions, we'd be happy to help :)

radu-matei avatar Oct 02 '18 15:10 radu-matei

Wondering if there is any progress on this issue. It is quite a reasonable requirement when we have pipelines to deploy already built docker images to another environment without having to build the images again.

veeramarni avatar Oct 08 '18 21:10 veeramarni

Whoops, I disappeared. The last month has been a bit busier then expected. Gonna take a look at this today.

zoidyzoidzoid avatar Oct 31 '18 09:10 zoidyzoidzoid

FYI, @zoidbergwill has already sent out an initial PR (thanks!): #899

max-baz avatar Nov 02 '18 13:11 max-baz

Please feel free to comment on it. I'll work on adding test coverage this weekend.

zoidyzoidzoid avatar Nov 02 '18 15:11 zoidyzoidzoid