draft-classic icon indicating copy to clipboard operation
draft-classic copied to clipboard

remove the embedded Azure SDK from Draft once ACR Build is in azure-sdk-for-go

Open bacongobbler opened this issue 7 years ago • 2 comments

refs discussion in #691

bacongobbler avatar Apr 23 '18 20:04 bacongobbler

@bacongobbler ACR Build is in azure-sdk-for-go and published in /preview so this item is unblocked now.

Ref: https://github.com/Azure/azure-sdk-for-go/tree/master/services/preview/containerregistry/mgmt/2018-02-01/containerregistry

There should be no major breaking changes from the work you did earlier in #691 but the models may be ever-so-slightly different since I believe you hand-crafted a few properties like DockerImages?

ehotinger avatar May 17 '18 21:05 ehotinger

Yeah, we'll also need to retain some things like util.go until we contribute that upstream. Thanks for the heads up!

bacongobbler avatar May 17 '18 22:05 bacongobbler