draft-classic icon indicating copy to clipboard operation
draft-classic copied to clipboard

rename --config/-f flag on draft init

Open michelleN opened this issue 7 years ago • 3 comments

#670 adds a flag on draft init that allows you to pass a toml file indicating which plugins and pack repositories you'd like to add/override when setting up draft. This makes it easier for orgs/teams that want to use custom plugins or their own draft pack repositories and don't want to do the manual draft plugin install and draft pack-repo add steps for each item.

--config/-f was put in for a quick mvp release of that functionality but we may want to think about if that is the right name for the flag at all. config is very overloaded. Should it be --custom or --defaults or --overrides or something else entirely?

If anyone has any thoughts here, they would be greatly appreciated.

This is also a great first issue for anyone looking to contribute. Bonus points for adding tests. :)

michelleN avatar Apr 19 '18 15:04 michelleN

okay so I need to play with the tool a bit before I have opinions on the naming of flags :)

jessfraz avatar Apr 20 '18 15:04 jessfraz

--custom-toml :-) --custom-app-config

squillace avatar Apr 20 '18 16:04 squillace

Hey folks, do we have any preference on this one? I would like to do the required change :) How about --config-file, --custom-config or --custom-config-file (really long flag)

bhavin192 avatar Oct 15 '18 16:10 bhavin192