draft-classic icon indicating copy to clipboard operation
draft-classic copied to clipboard

configure things in draft.toml on the command line on `draft up`

Open michelleN opened this issue 8 years ago • 4 comments

michelleN avatar Jun 26 '17 18:06 michelleN

Can this be closed?

radu-matei avatar Mar 26 '18 21:03 radu-matei

Not quite yet. Once you can do a draft up --set service.type=LoadBalancer I think we can consider this one closed. :)

bacongobbler avatar May 03 '18 04:05 bacongobbler

👍 on this, but I would generalize it beyond the above example draft up --set service.type=LoadBalancer. For example, the current custom-tags is quite restrictive as it does not seem possible to inject some shell result such as the current gitsha there. Without this, it becomes harder to associate draft releases with the gitsha, which would be useful for reproducibly referencing the images by gitsha from kubernetes yamls (perhaps generated through helm charts).

(I recognise this use case has kind of a CI/CD flavour to it, which is in fact what we are trying to use it for.)

In order to work around this, there would probably need to be some pre-up plugin to capture the gitsha and overwrite the custom-tags in draft.toml

omnilinguist avatar Jun 08 '18 16:06 omnilinguist

It is not our intention at this time to make draft anything other than a dev ux tool that works beautifully with the artifacts others use, so we will likely tread carefully here.

It can certainly be used that way, but I'm not yet clear we should extend full features like this...

squillace avatar Jun 08 '18 17:06 squillace