doAzureParallel icon indicating copy to clipboard operation
doAzureParallel copied to clipboard

Fix: Option to set maximum expiry date for task completion upload tokens

Open zerweck opened this issue 5 years ago • 4 comments

Proposed fix for #363

zerweck avatar Aug 06 '19 12:08 zerweck

CLA assistant check
All CLA requirements met.

msftclas avatar Aug 06 '19 12:08 msftclas

No Idea why Travis failed :/

zerweck avatar Aug 06 '19 14:08 zerweck

Looking at the build log, it doesn't seem like a problem related to my diff. Is it possible to just re-run the build?

zerweck avatar Aug 07 '19 12:08 zerweck

Hey @zerweck

Thanks for the PR! Appreciate it -- can you also update the docs so other users can use it (https://github.com/Azure/doAzureParallel/blob/master/docs/52-azure-foreach-options.md)? I'll take a look into why the build is failing. I'm also taking a look at some other better namings of the parameter.

I'm leaning towards fileSasExpiryTime or containerSasExpiryTime instead of a maxDate.

Thanks, Brian

brnleehng avatar Aug 07 '19 16:08 brnleehng