device-simulation-dotnet icon indicating copy to clipboard operation
device-simulation-dotnet copied to clipboard

Improved gps location device simulation

Open joelhulen opened this issue 7 years ago • 2 comments

Type of change?

  • [x] Bug fix
  • [ ] New feature
  • [x] Enhancement
  • [ ] Breaking change (breaks backward compatibility)

Description, Context, Motivation

The previous version never actually changed the truck's location after the first pass. This version randomizes the changed distance, plus it adds a rounding function that handles the positive and negative values of the lat/long coordinates equally well. This results in an improved randomized route for the trucks. Not 100% realistic (data would need to be incorporated for that), but good enough for a simulation.

Checklist:

  • [ ] All tests passed
  • [x] The code follows the code style and conventions of this project
  • [ ] The change requires a change to the documentation
  • [ ] I have updated the documentation accordingly

This change is Reviewable

joelhulen avatar Jan 22 '18 02:01 joelhulen

@joelhulen thanks for the PR, we're looking into it

dluc avatar Jan 22 '18 03:01 dluc

@peterfelts could you look at this PR?

dluc avatar May 12 '18 23:05 dluc