data-landing-zone icon indicating copy to clipboard operation
data-landing-zone copied to clipboard

Alter wording of "Deploy Self-Host Integration Runtimes"

Open mboswell opened this issue 3 years ago • 7 comments

In the one click deployment of a Data Landing Zone, the wording of "Deploy Self-Host Integration Runtimes" needs to be clearer that these SHIR are for Purview. Suggestion would be to change wording to "Deploy Self-Host Integration Runtimes for Purview"

DLZ-SHIR

mboswell avatar Nov 15 '21 12:11 mboswell

Thanks @mboswell for submitting this. But the button here is for the user to decide whether a SHIR for Purview AND Data Factory should be deployed. Not just Purview. What would be your suggestion under these circumstances?

marvinbuss avatar Nov 16 '21 09:11 marvinbuss

Please create two buttons - one for data factory and one of Purview as they are two separate SHIR and reside in two separate RGs.

From: Marvin Buss @.> Sent: 16 November 2021 09:11 To: Azure/data-landing-zone @.> Cc: Mike Boswell @.>; Mention @.> Subject: Re: [Azure/data-landing-zone] Alter wording of "Deploy Self-Host Integration Runtimes" (Issue #210)

Thanks @mboswellhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmboswell&data=04%7C01%7Cmboswell%40microsoft.com%7C32935021d6ef44309b3508d9a8e10135%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637726506637346924%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=l7kTSlhFZUViX63R5M%2FIVbmqd6iAXAD2fsNepKW8YC0%3D&reserved=0 for submitting this. But the button here is for the user to decide whether a SHIR for Purview AND Data Factory should be deployed. Not just Purview.

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fdata-landing-zone%2Fissues%2F210%23issuecomment-970068655&data=04%7C01%7Cmboswell%40microsoft.com%7C32935021d6ef44309b3508d9a8e10135%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637726506637356916%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=gNVZqXVdeHFqxdfNMcXCxO8ssSSPgY42ReEC3KaupTg%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFMTAF6DDP3AMTLB2LRZHYTUMIN2FANCNFSM5IBRYFWQ&data=04%7C01%7Cmboswell%40microsoft.com%7C32935021d6ef44309b3508d9a8e10135%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637726506637356916%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Oh%2FUo%2Fwnla4%2F%2FAyqbiSDmJDZIN18IQJXAjG6Whh6OC4%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Cmboswell%40microsoft.com%7C32935021d6ef44309b3508d9a8e10135%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637726506637366915%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Wmg8k8H2Km%2FX1QLu16%2BrnG2Y0mOaTu5fIFNYoZmaz0o%3D&reserved=0 or Androidhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Cmboswell%40microsoft.com%7C32935021d6ef44309b3508d9a8e10135%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637726506637376911%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=aRKoT0tSYtAmaYiZbW%2Bqu4%2BM2eckYV3TsIEd%2BIEmkao%3D&reserved=0.

mboswell avatar Nov 16 '21 09:11 mboswell

Hi @mboswell, Have you seen this: image

image

Any feedback? Thank you!

marvinbuss avatar Nov 17 '21 15:11 marvinbuss

The help bubble is a good start but please can we put this into the text of "Deploy Self-hosted Integration Runtimes" to say "Deploy Self-hosted Integration Runtimes for Data Factory and Purview". The help text then explains that two VMSS sets will be created.

mboswell avatar Nov 17 '21 19:11 mboswell

But they are not both created. The second one cannot be created without the user providing the Key for the Purview SHIR Instance. Therefore, this change would be misleading for users.

marvinbuss avatar Nov 18 '21 08:11 marvinbuss

Sorry, this was by mistake, because I linked the wrong issue to the other PRs, but I reopened the issue earlier already.

marvinbuss avatar Nov 18 '21 14:11 marvinbuss

This is what we are looking for...

  • SHIRs in the shared integration resource group which is linked the data factory there.
  • SHIR which are in the metadata resource group which are linked to Purview.

Hence breaking this out into two options as customer won't always have both ADF and Purview. Some might only have Purview and others only Data Factory.

SHIR-Purview-ADF

mboswell avatar Nov 18 '21 15:11 mboswell