data-api-builder icon indicating copy to clipboard operation
data-api-builder copied to clipboard

Determine Social Provider Login Support (Facebook, Google) with StaticWebApps & App Service

Open seantleonard opened this issue 3 years ago • 12 comments

Evaluate whether social providers include roles in their access tokens, i.e. via a role claim.

  • If role claim(s) are included:
    • Can an end user can arbitrarily add themselves to roles or is that capability limited to FB app/enterprise admins?
      • If users can arbitrarily add themselves to roles, ensure we do NOT honor those roles to determine access in DAB engine and see whether SWA/AppService passes those roles through in the EasyAuth payload.
      • If just enterprise admins can manage roles/role assignments, no issues.
        • Check whether SWA/AppService passes those roles through in the EasyAuth payload. If not, developers must manage roles through SWA Azure Function Integration.
  • No Role claims included:
    • Developers must manage roles through SWA Azure Functions (preview) Integration.

seantleonard avatar Aug 18 '22 16:08 seantleonard

Default branch for gitlab is main too according to the documentation

StephanEggermont avatar Apr 25 '24 14:04 StephanEggermont

🤷‍♂️When I created a blank project and loaded it into GT I got a master branch.

onierstrasz avatar Apr 25 '24 14:04 onierstrasz

Is this gitlab.com or a self-hosted GitLab instance? If it’s self-hosted, which version is it? On gitlab.com, the default branch is indeed main; I just created one myself.

hellerve avatar Apr 25 '24 14:04 hellerve

Good question. I thought it was gitlab.com, but maybe it is a unibe hosted instance. I'll have to check!

onierstrasz avatar Apr 25 '24 15:04 onierstrasz

Thank you! In the meantime, I’ve fixed the other issue. The parser should now also handle gitlab.com (but not self-hosted instances!). It will also throw a hopefully more instructive error when trying to add the Baseline information to the README otherwise.

hellerve avatar Apr 25 '24 15:04 hellerve

Nice! Though there seems to be an unnecessary st now in the installation script. Can you please check, @hellerve ?

Screenshot 2024-04-28 at 14 19 05

onierstrasz avatar Apr 28 '24 12:04 onierstrasz

I didn’t change it, but that is a Smalltalk syntax cue (https://www.markdownguide.org/extended-syntax/#syntax-highlighting). It should be supported by GitHub, GitLab, and GT.

hellerve avatar Apr 28 '24 19:04 hellerve

That's odd. Until I deleted it, it messed up the display of the README on my test repo on GitLab. Can't we get rid of it?

onierstrasz avatar Apr 28 '24 20:04 onierstrasz

Well, now I can't reproduce the problem. I will have to create a new repo and see if I can recreate the issue ...

onierstrasz avatar Apr 28 '24 20:04 onierstrasz

OK, I verified that it does not work in GitLab. Is it possible to remove the st syntax cue for GitLab?

Screenshot 2024-04-29 at 07 54 26

onierstrasz avatar Apr 29 '24 05:04 onierstrasz

Can you try adding an empty line after Installation?

Also, if that does not help, what happens if you use smalltalk instead of st?

girba avatar Apr 29 '24 07:04 girba

Oh, with Andreas we discovered that the problem is that the newlines are wrong, not the st! Just editing the README on the GitLab web page and saving it fixes the issues.

onierstrasz avatar Apr 29 '24 07:04 onierstrasz

Hm, it looks like GitLab expects specific newlines where GitHub is happy with any. We are not doing anything specific to the newlines in the file, so this is the default behaviour with regards to newlines.

I’ll leave the st as is for now, then.

hellerve avatar Apr 29 '24 11:04 hellerve