data-api-builder icon indicating copy to clipboard operation
data-api-builder copied to clipboard

Hot Reload Validation

Open RubenCerna2079 opened this issue 1 year ago • 2 comments

Why make this change?

This change fixes issue #2396

What is this change?

The main changes were made to the RuntimeConfigProvider file to make sure that it validates the config file before returning it to ensure that it is validated. RuntimeConfigLoader and FileSystemRuntimeConfigLoader were also changed to accommodate this change and new logic was added so that in case the config validation failed, DAB could still work without any problems.

How was this tested?

  • [X] Integration Tests
  • [ ] Unit Tests

RubenCerna2079 avatar Oct 02 '24 22:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 03 '24 04:10 RubenCerna2079

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Oct 03 '24 04:10 azure-pipelines[bot]

/azp run

RubenCerna2079 avatar Oct 11 '24 18:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 11 '24 21:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 11 '24 22:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 17 '24 17:10 RubenCerna2079

This is great and the way that you update with the Last Known Good will close this bug here: https://github.com/Azure/data-api-builder/issues/2418

So you can added the closes tag for that issue to the PR description.

Once you address the comments should be good to go.

aaronburtle avatar Oct 18 '24 07:10 aaronburtle

/azp run

RubenCerna2079 avatar Oct 21 '24 19:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 21 '24 22:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 24 '24 03:10 RubenCerna2079

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Oct 24 '24 03:10 azure-pipelines[bot]

/azp run

RubenCerna2079 avatar Oct 24 '24 03:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 24 '24 04:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 24 '24 16:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 24 '24 17:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 24 '24 18:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 25 '24 19:10 RubenCerna2079

/azp run

RubenCerna2079 avatar Oct 25 '24 23:10 RubenCerna2079

/azp run

Aniruddh25 avatar Oct 29 '24 16:10 Aniruddh25

/azp run

RubenCerna2079 avatar Oct 30 '24 04:10 RubenCerna2079

/azp run

abhishekkumams avatar Oct 30 '24 05:10 abhishekkumams