Azure
Fix DataSourceName update for HotReload
Why make this change?
the correct way of updating the dataSourceName was already there in the initial PR here: https://github.com/Azure/data-api-builder/blob/741865371911ef0b8dc6a27d9bc9ef82470cfc16/src/Config/ObjectModel/RuntimeConfig.cs#L303
then in another refactor PR, it was incorrectly updated, ref: https://github.com/Azure/data-api-builder/pull/2356/files#r1781334859
What is this change?
- Using the correct initial method to update the DataSourceName for HotReload Scenario.
How was this tested?
- Manual Testing
- More tests should be a part of other HotReload PRs
In the tests section you wrote that "more tests should be part of other HotReload PRs". Do you mean tests related to the function UpdateDefaultDataSourceName or what did you mean by it?
In the tests section you wrote that "more tests should be part of other HotReload PRs". Do you mean tests related to the function
UpdateDefaultDataSourceNameor what did you mean by it?
correct integrations tests would be verifying this update logic as well.
It would be helpful to have in PR description "Why" this change is correct and why the previous one is wrong
