data-api-builder icon indicating copy to clipboard operation
data-api-builder copied to clipboard

Remove isDevelopmentMode from the ISqlMetadataProvider, SqlMetadataProvider, and CosmosSqlMetadataProvider

Open aaronburtle opened this issue 1 year ago • 0 comments

We currently have a function called IsDevelopmentMode which is a part of the interface ISqlMetadataProvider. Therefore, the SqlMetdataProvider and the CosmosSqlMetadataProvider classes both implement this function.

However, all this function is doing is passing along some values that return from the RuntimeConfigProvider. This function is not used by the classes themselves and appears to be a case of the class handling something that is not its responsibility. We should instead favor simply using the RuntimeConfigProvider to determine if we are in development mode.

From the SqlMetadataProvider: image

aaronburtle avatar Aug 31 '24 00:08 aaronburtle