data-api-builder icon indicating copy to clipboard operation
data-api-builder copied to clipboard

Replace copies of RuntimeConfig with RuntimeConfigProvider

Open aaronburtle opened this issue 1 year ago • 1 comments
trafficstars

As laid out in the design document https://microsoft.sharepoint.com/:w:/r/teams/AzureDataMultiverseExperience/_layouts/15/Doc.aspx?sourcedoc=%7B0026b3cf-cc3e-4ce7-8b7d-865c17151f4d%7D&action=edit&wdPid=4859d50d&share=IQHPsyYAPsznTIt9hlwXFR9NARKmccDqULBmAGCcOV2MzhQ there are classes we currently use, such as the SqlMetaDataProvider, OpenApiDocumentor, and CostmosSqlMetaDataProvider, that save internal copies of the RuntimeConfig. These classes instead should have a copy of the RuntimeConfigProvider, and when a runtimeconfig is needed they should instead get that runtimeconfig from the provider as needed. This will cause the runtimeconfig to always be the most up to date copy.

aaronburtle avatar Aug 09 '24 21:08 aaronburtle

@aaronburtle the design doc is not publicly accessible. Doesn't need to be referenced here unless you end up created a markdown file to include in this repo

seantleonard avatar Aug 09 '24 22:08 seantleonard

@aaronburtle the design doc is not publicly accessible. Doesn't need to be referenced here unless you end up created a markdown file to include in this repo

thanks for pointing that out Sean, ill remove from these issues.

aaronburtle avatar Aug 13 '24 21:08 aaronburtle