communication-ui-library icon indicating copy to clipboard operation
communication-ui-library copied to clipboard

Published 20 hours ago • verified publisher icon Azure

[CallReadiness] unsupported browser check handlers

Open dmceachernmsft opened this issue 2 years ago • 5 comments

What

adds handlers to the CallingStatefulClient and CallAdapter to get environment information.

Why

Allows us to use the Calling SDK to check whether the end user is using a supported browser

https://skype.visualstudio.com/SPOOL/_workitems/edit/2980686

How Tested

dmceachernmsft avatar Oct 05 '22 22:10 dmceachernmsft

Storybook URL https://60c7ae6891f0e90039d7cd54-urlqjmwcct.chromatic.com/

github-actions[bot] avatar Oct 06 '22 17:10 github-actions[bot]

CallWithChat bundle size is increased❗.

  • Current size: 5640149
  • Base size: 5638359
  • Diff size: 1790

github-actions[bot] avatar Oct 06 '22 17:10 github-actions[bot]

Calling bundle size is increased❗.

  • Current size: 5254574
  • Base size: 5252744
  • Diff size: 1830

github-actions[bot] avatar Oct 06 '22 17:10 github-actions[bot]

Chat bundle size is decreased✅.

  • Current size: 5373631
  • Base size: 5373767
  • Diff size: -136

github-actions[bot] avatar Oct 06 '22 17:10 github-actions[bot]

blocked on Calling API.

Current behavior is the constructor for the call client fails so we cannot utilize the handlers in this PR. Will update when path forward

dmceachernmsft avatar Oct 08 '22 01:10 dmceachernmsft

Closing this, revised in this PR: https://github.com/Azure/communication-ui-library/pull/2479

dmceachernmsft avatar Nov 02 '22 18:11 dmceachernmsft