communication-ui-library icon indicating copy to clipboard operation
communication-ui-library copied to clipboard

Validate identifier before creating the adapter

Open PorterNan opened this issue 3 years ago • 3 comments

What

Add an identifier sanity before we really involve function to create identifier

Why

How Tested

Process & policy checklist

  • [ ] I have updated the project documentation to reflect my changes if necessary.
  • [ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • [ ] This change causes current functionality to break.

PorterNan avatar Sep 08 '22 00:09 PorterNan

Storybook URL https://60c7ae6891f0e90039d7cd54-vuabunnmff.chromatic.com/

github-actions[bot] avatar Sep 08 '22 00:09 github-actions[bot]

Anything blocking this PR?

prprabhu-ms avatar Oct 13 '22 18:10 prprabhu-ms

Removing from my attention set.

prprabhu-ms avatar Oct 13 '22 18:10 prprabhu-ms

Please reassign me if you need me to take another look.

edwardlee-msft avatar Nov 21 '22 18:11 edwardlee-msft

Storybook URL https://60c7ae6891f0e90039d7cd54-ggijukggzx.chromatic.com/

github-actions[bot] avatar Dec 13 '22 23:12 github-actions[bot]

Storybook URL https://60c7ae6891f0e90039d7cd54-cqlhawbszd.chromatic.com/

github-actions[bot] avatar Dec 13 '22 23:12 github-actions[bot]

Chat bundle size is increased❗.

  • Current size: 5575052
  • Base size: 5574900
  • Diff size: 152

github-actions[bot] avatar Dec 13 '22 23:12 github-actions[bot]

CallWithChat bundle size is increased❗.

  • Current size: 5868375
  • Base size: 5868135
  • Diff size: 240

github-actions[bot] avatar Dec 13 '22 23:12 github-actions[bot]

Calling bundle size is increased❗.

  • Current size: 5480515
  • Base size: 5480372
  • Diff size: 143

github-actions[bot] avatar Dec 13 '22 23:12 github-actions[bot]

Storybook URL https://60c7ae6891f0e90039d7cd54-smodfyxqkf.chromatic.com/

github-actions[bot] avatar Dec 14 '22 00:12 github-actions[bot]

Storybook URL https://60c7ae6891f0e90039d7cd54-hrlaiwmsvh.chromatic.com/

github-actions[bot] avatar Dec 14 '22 05:12 github-actions[bot]