communication-ui-library
communication-ui-library copied to clipboard
Azure
Composite end call screen when room call join fails
What
Using subcodes from Calling SDK to show a different end call screen in the composite when call is ended because:
- room does not exist
- user was not invited to room
The end call screens were added to composite instead of the sample as discussed with @alkwa-msft. Also, composite users will be much more informed when a room call join fails.
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/2966741 https://skype.visualstudio.com/SPOOL/_workitems/edit/2966748
How Tested
Tested with call composite preview in storybook.
-
When room does not exist https://user-images.githubusercontent.com/79475487/187261071-2ace3bc3-26a8-4f07-a3b9-0073ff2efb5b.mp4
-
When user was not invited to the room https://user-images.githubusercontent.com/79475487/187261180-64b5f24b-7083-45eb-a63f-569d04140eab.mp4
Process & policy checklist
- [ ] I have updated the project documentation to reflect my changes if necessary.
- [ ] I have read the CONTRIBUTING documentation.
Is this a breaking change?
- [ ] This change causes current functionality to break.
Storybook URL https://60c7ae6891f0e90039d7cd54-wcdaryiqby.chromatic.com/
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Calling bundle size is increased❗.
- Current size: 5069512
- Base size: 5068284
- Diff size: 1228
CallWithChat bundle size is increased❗.
- Current size: 5455011
- Base size: 5453783
- Diff size: 1228
Chat bundle size is increased❗.
- Current size: 5194253
- Base size: 5193876
- Diff size: 377
Storybook URL https://60c7ae6891f0e90039d7cd54-zasrpjnfvf.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-gprnsvtjaz.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-unydwjmltz.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-thmqtqgxgc.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-kidhvwifmy.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-qhsxxfhmcc.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-fxquwjcude.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-nuhdumvkya.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-vovjewnkua.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-aebbtlmpzd.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-olrkslvyfe.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-jtdsvwahaa.chromatic.com/
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.
Storybook URL https://60c7ae6891f0e90039d7cd54-kcshrjooux.chromatic.com/
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.
Storybook URL https://60c7ae6891f0e90039d7cd54-zojhusuztl.chromatic.com/
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.
Storybook URL https://60c7ae6891f0e90039d7cd54-ujriilbssi.chromatic.com/
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.
Storybook URL https://60c7ae6891f0e90039d7cd54-jnvncmhksn.chromatic.com/
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.
Storybook URL https://60c7ae6891f0e90039d7cd54-olutlpuere.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-kyxuhmzkiz.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-wbeahwbzhs.chromatic.com/
Storybook URL https://60c7ae6891f0e90039d7cd54-diinckgjog.chromatic.com/