communication-ui-library icon indicating copy to clipboard operation
communication-ui-library copied to clipboard

Rooms storybook conceptual docs

Open mgamis-msft opened this issue 2 years ago • 6 comments

What

Added rooms conceptual docs in storybook

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/2952557

How Tested

Verified Rooms page works on local storybook Please see Rooms page under the Concepts section in the generated Chromatic storybook site

Process & policy checklist

  • [ ] I have updated the project documentation to reflect my changes if necessary.
  • [ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • [ ] This change causes current functionality to break.

mgamis-msft avatar Aug 25 '22 06:08 mgamis-msft

Storybook URL https://60c7ae6891f0e90039d7cd54-wuwtkfzvyp.chromatic.com/

github-actions[bot] avatar Aug 25 '22 06:08 github-actions[bot]

Calling bundle size is decreased✅.

  • Current size: 5067519
  • Base size: 5067520
  • Diff size: -1

github-actions[bot] avatar Aug 25 '22 06:08 github-actions[bot]

CallWithChat bundle size is decreased✅.

  • Current size: 5452908
  • Base size: 5452909
  • Diff size: -1

github-actions[bot] avatar Aug 25 '22 06:08 github-actions[bot]

Chat bundle size is decreased✅.

  • Current size: 5193320
  • Base size: 5193321
  • Diff size: -1

github-actions[bot] avatar Aug 25 '22 06:08 github-actions[bot]

Storybook URL https://60c7ae6891f0e90039d7cd54-xbjlawddcf.chromatic.com/

github-actions[bot] avatar Aug 25 '22 08:08 github-actions[bot]

Feedback:

  • Can we update the diagram to remove red lines under some of the items
  • I think we should update the composite documentation to include some references to the rooms doc. Particularly we might want to call out the set of modalities supported.
  • For FAQ #2, can we add a link to the identity quickstarts

ddematheu2 avatar Aug 29 '22 18:08 ddematheu2

Feedback:

  • Can we update the diagram to remove red lines under some of the items
  • I think we should update the composite documentation to include some references to the rooms doc. Particularly we might want to call out the set of modalities supported.
  • For FAQ Enable CI Pipeline #2, can we add a link to the identity quickstarts

Thank you for the feedback! I have made the necessary updates.

mgamis-msft avatar Sep 01 '22 14:09 mgamis-msft

Storybook URL https://60c7ae6891f0e90039d7cd54-tjicigzraz.chromatic.com/

github-actions[bot] avatar Sep 01 '22 15:09 github-actions[bot]

Storybook URL https://60c7ae6891f0e90039d7cd54-ukwysuujun.chromatic.com/

github-actions[bot] avatar Sep 09 '22 18:09 github-actions[bot]