blobxfer
blobxfer copied to clipboard
Fix 144, add support for Managed Disk SAS tokens
Pull Request Checklist
- [x] Review the contributing guidelines
- [x] Outstanding issue linked, if applicable
- [x] PR should only be opened against
master
if it includes no features (open againstdevelop
otherwise) - [x] Commit messages should conform to good style practices
- [x] PR should pass all checks and have no conflicts
Description
Re-works the domain parsing for mode
and ep
to work with managed disk URLs and all existing URLs as well.
Fixes #144
Hmm, CI failure looks to be caused by the CI using tox
4 or newer: the tox.ini
rules have changed. See https://tox.wiki/en/latest/upgrading.html
Fixing that bit of outdated config to get CI working..
Looks like the CI is still broken, this time because of a codecov usage problem:
/home/vsts/work/_temp/c77f6f39-378b-4090-ac61-942334cc01a5.sh: line 4: codecov.uploadToken: command not found
usage: codecov [-h] [--version] [--token TOKEN] [--file [FILE [FILE ...]]]
[--flags [FLAGS [FLAGS ...]]] [--env [ENV [ENV ...]]]
[--required] [--name NAME] [--gcov-root GCOV_ROOT]
[--gcov-glob [GCOV_GLOB [GCOV_GLOB ...]]]
[--gcov-exec GCOV_EXEC] [--no-gcov-out] [--gcov-args GCOV_ARGS]
[-X [DISABLE [DISABLE ...]]] [--root ROOT] [--commit COMMIT]
[--prefix PREFIX] [--branch BRANCH] [--build BUILD] [--pr PR]
[--tag TAG] [--tries TRIES] [--slug SLUG] [--url URL]
[--cacert CACERT] [--dump] [-v] [--no-color]
codecov: error: argument --token/-t: expected one argument
I'll leave the fixing of that one up to the repo maintainers, I've used as much time on this today as I can afford. I recommend that the maintainers pin the versions of the tools they are using in their CI.