bicep icon indicating copy to clipboard operation
bicep copied to clipboard

Investigate: Support ACR module reference completions

Open bhsubra opened this issue 3 years ago • 8 comments

Support ACR module reference completions. Part of #3964

bhsubra avatar Nov 15 '22 18:11 bhsubra

@StephenWeatherford, let's investigate and document the options here.

puicchan avatar May 09 '24 21:05 puicchan

Could you please clarify. Is auto-completion supposed to work for private registries in VSCode or not? It works fine for public registries but doesn't work for private ones.

image

and no auto-completion for private registry. The module has been detected and works fine, just no auto completion (intellisense)

It looks like this issue relates to it, but I'm not sure. The issue was renamed (initially it was support, now investigate), the milestone has been moved several times. Sorry if it's something else and doesn't relate to auto-completion for private registries.

GSerjo avatar Sep 17 '24 16:09 GSerjo

This is definitely something we'd like to do but other priorities have pushed it behind. I'm hoping we can get to it within the next few milestones.

StephenWeatherford avatar Oct 04 '24 21:10 StephenWeatherford

One other potential enhancement: I noticed if I type a '/' in the registry path, completion is no longer provided (see below) I think it makes sense to make this work similarly to how resource namespace completions work.

https://github.com/user-attachments/assets/51ceb7a4-8582-4bb5-b92f-8eb62c522a1e

levimatheri avatar Oct 04 '24 22:10 levimatheri

Yes, that is definitely annoying, the completions were implemented incorrectly here. Someday hopefully I'll get to fixing that.

StephenWeatherford avatar Oct 04 '24 23:10 StephenWeatherford

@levimatheri I'd actually suggest you create a new bug for this, if one doesn't already exist. It's separate to the private ACR completions.

StephenWeatherford avatar Oct 04 '24 23:10 StephenWeatherford

Created bug item

levimatheri avatar Oct 07 '24 17:10 levimatheri

Looking forward for this feature as I'm structuring a global ACR structure for the enterprise and would be great if the development teams could consume it without having to access the Portal to get a list of available modules and their versions.

diogocatossi avatar Oct 11 '24 08:10 diogocatossi

Helo. Happy New Year! Do you have any updates on that? Especially in the context of private ACR (AVM). It works fine with public, but not so much with private :(.

dariuszbz avatar Jan 02 '25 10:01 dariuszbz

@dariuszbz Thanks! Working on it now.

StephenWeatherford avatar Jan 03 '25 03:01 StephenWeatherford

For 1st iteration - make sure we include module's description (P1) and link to View documentation (if possible.)

puicchan avatar Jan 09 '25 22:01 puicchan

@dariuszbz @diogocatossi Please try it out, let me know if you run into any issues: https://github.com/Azure/bicep/pull/16051#issuecomment-2581253846

StephenWeatherford avatar Feb 06 '25 00:02 StephenWeatherford

@dariuszbz @diogocatossi Please try it out, let me know if you run into any issues: #16051 (comment)

@StephenWeatherford for which version this will be released? Currently Bicep extension is version 0.33.93 from 2025-01-30, 19:36:26, I believe it's in pull request stage so merge didn't happen and I'm not sure we can test it.

At the moment it fetches all the ACRs your current context has access to but doesn't goes further to list the repositories, paths and tags like it's done for mcr/avm:

Image

Image

Image

diogocatossi avatar Feb 06 '25 11:02 diogocatossi

@diogocatossi Run the appropriate script from the comment I linked to to install the vscode extension version with the changes. Afterwards you can set it back to the 0.33 version (doesn't affect bicep CLI, only vscode extension).

StephenWeatherford avatar Feb 06 '25 17:02 StephenWeatherford

@StephenWeatherford thank you for the new feature and the extension url. It works great. I was able to see our modules from the private acr.

GSerjo avatar Feb 06 '25 23:02 GSerjo