bicep icon indicating copy to clipboard operation
bicep copied to clipboard

We should get rid of the "resource-{,without-}defaults" and "resource-child-{,without-}defaults" snippets

Open StephenWeatherford opened this issue 2 years ago • 8 comments

image

We should check telemetry, but I'm guessing these are rarely used. I think we should at least get rid of the "without-defaults" versions.

  1. Now that we have lots of resource snippets, I think these just clutter up the namespace and cause confusion:
  2. They're not really useful (esp the without-defaults ones), you can just type "resource" and use intellisense
  3. They lead you away from the better intellisense experience of having properties automatically filled out from the actual resource type once you've selected it: image

StephenWeatherford avatar Jan 20 '22 21:01 StephenWeatherford

TODO: Check telemetry for usage and get back to triage with recommendations.

StephenWeatherford avatar Jan 27 '22 02:01 StephenWeatherford

+1, I think the 'required-properties' snippet is way more valuable as it's type-aware; I'd much rather point people towards that.

anthony-c-martin avatar Jan 27 '22 02:01 anthony-c-martin

Agree. If telemetry shows no meaningful usage, we should remove.

majastrz avatar Jan 27 '22 03:01 majastrz

@StephenWeatherford after findings in telemetry usage, I support removing both. #sign-off

ucheNkadiCode avatar Feb 02 '22 19:02 ucheNkadiCode

All four? image

StephenWeatherford avatar Feb 02 '22 20:02 StephenWeatherford

Plan is to get rid of the above 4 and replace with single "resource" snippet that fills in the following:

resource {name} '{provider/type}@{api-version}' = 

With tab stops in the spots with {...}

alex-frankel avatar Feb 02 '22 20:02 alex-frankel

Work with Mikolaj and Ben.

StephenWeatherford avatar Feb 02 '22 20:02 StephenWeatherford

P1 for next milestone

StephenWeatherford avatar Aug 04 '22 18:08 StephenWeatherford