Upgrade from upload-artfact@v3 to v4 when breaking changes are fixed or better guidance given.

[StephenWeatherford]

See https://github.com/Azure/bicep/pull/12802

The effect on us at the moment that we've seen is that artifacts don't show up on the build page (eg https://github.com/Azure/bicep/actions/runs/7252241798#artifacts) except for auto-triggered CI runs (e.g. https://github.com/Azure/bicep/actions/runs/7252057055).

[anthony-c-martin]

This comment feels like it could explain the behavior we were seeing: https://github.com/actions/upload-artifact/issues/472#issuecomment-1863194820

The workaround of embedding the job name & index doesn't feel practical for our use cases.

[StephenWeatherford]

Still not seeing clear guidance...

[StephenWeatherford]

https://github.com/orgs/aio-libs/discussions/31

webknjaz on Jan 2 Maintainer Author UPD: Enough people report more flakiness with the v4 (the download failing before the upload catches up with the CDN). So the advice is still to stick with v3 for the time being.

[StephenWeatherford]

Fixed with #13992