azure-workload-identity icon indicating copy to clipboard operation
azure-workload-identity copied to clipboard

Published 20 hours ago • verified publisher icon Azure

feat(helmchart): configurable securityContext

Open zetamorph opened this issue 2 years ago • 4 comments

Reason for Change:

This commit moves the currently configured securityContext to the Helm values so that the default securityContext stays the same, but can be overridden if needed.

In some environments, a hardcoded container securityContext can cause problems. E.g. in OpenShift, a container's securityContext.runAsUser needs to be set to a namespace-specific UID.

Requirements

  • [x] squashed commits
  • [x] included documentation
  • [ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • [ ] yes
  • [x] no

Notes for Reviewers:

zetamorph avatar Nov 17 '23 13:11 zetamorph

@microsoft-github-policy-service agree

zetamorph avatar Nov 20 '23 23:11 zetamorph

Hi @aramase @enj,

I see that you have been assigned as the reviewers for this PR. Did you already have a chance to review the changes?

zetamorph avatar Jan 03 '24 15:01 zetamorph

Hi @aramase @enj, Do you have any updates for this PR?

3deep5me avatar Mar 13 '24 14:03 3deep5me

@aramase @enj

Did you already have a chance to look at this PR?

zetamorph avatar Mar 21 '24 08:03 zetamorph