azure-webpubsub icon indicating copy to clipboard operation
azure-webpubsub copied to clipboard

Questions about protobuf protocols

Open corradocavalli opened this issue 1 year ago • 1 comments

I'm implementing the missing protobuf protocols and i think that the documentation here is incorrect as it should be:

oneof message { SendToGroupMessage send_to_group_message = 1; EventMessage event_message = 5; JoinGroupMessage join_group_message = 6; LeaveGroupMessage leave_group_message = 7; SequenceAckMessage sequence_ack_message = 8; }

Is also not clear to me what is the role of the WriteMessage override since it is never called. Plan to contribute with a PR once implementation will be completed.

corradocavalli avatar Jul 20 '23 15:07 corradocavalli

Got confirmed that WriteMessage is not used at the moment, so just the documentation has to be fixed now.

corradocavalli avatar Jul 21 '23 07:07 corradocavalli