Bug: Possible test race condition

[theunrepentantgeek]

Describe the bug

In the lead up to the release of ASO v2.10 we observed the test Test_Networking_PrivateEndpoint_WithoutAutoApproval_CRUD failing with an error in the task controller:test-integration-kind-ci:

No future change is possible.  Bailing out early after 20.016s.
Expected
    <conditions.Condition>: {
        Type: "Ready",
        Status: "False",
        Severity: "Error",
        LastTransitionTime: {
            Time: 2024-10-21T21:56:22Z,
        },
        ObservedGeneration: 1,
        Reason: "InvalidValuesForRequestParameters",
        Message: "Call to Microsoft.Storage/storageAccounts failed. 
			Error message: Values for request parameters are invalid: linkIdentifier.: 
			PUT https://management.azure.com/subscriptions/***/resourceGroups/asolivetest-rg-abwpdx/providers/Microsoft.Network/privateEndpoints/asolivetest-endpoint-iqaqky
			--------------------------------------------------------------------------------
			RESPONSE 400: 400 Bad Request
			ERROR CODE: InvalidValuesForRequestParameters
			--------------------------------------------------------------------------------
			{
				\"error\": {
					\"code\": \"InvalidValuesForRequestParameters\",
					\"message\": \"Call to Microsoft.Storage/storageAccounts failed. 
						Error message: Values for request parameters are invalid: linkIdentifier.\",
					\"details\": []
				}
			}
			--------------------------------------------------------------------------------",
    }
status to be "False", severity to be "Warning".

To Reproduce

Reproduction will be by running the task controller:test-integration-kind-ci, possibly with a TEST_FILTER to limit the test to Test_Networking_PrivateEndpoint_WithoutAutoApproval_CRUD, however this normally works so you may need several attempts.

Reviewing the test run that failed may be helpful for context.

Expected behavior

Test should consistently pass or fail.