PostReconcileCheck not running on BackupVaultBackupInstance resource

[mayankagg9722]

trafficstars

Version

ASO v2.7.0

Describe the bug Seeing a regressed behavior where there is no post reconciliation and BeginSyncBackupInstance called on the BackupVaultsBackupInstance even though it was failed user error and in protection error state (our condition in post reconciliation)

https://github.com/mayankagg9722/azure-service-operator/blob/e66c3fd05fc6af0a4efb0551b858d01eee2c7376/v2/api/dataprotection/customizations/backup_vaults_backup_instance_extensions.go#L98

To Reproduce Post performing all the prerequisutes, create the BackupVaultBackupInstance resource in the cluster using ASO. Use this Yaml: bie2etest.txt

Expected behavior BeginSyncBackupInstance should be called which is there in the reconciliation flow.

https://github.com/mayankagg9722/azure-service-operator/blob/e66c3fd05fc6af0a4efb0551b858d01eee2c7376/v2/api/dataprotection/customizations/backup_vaults_backup_instance_extensions.go#L98

Screenshots Activity logs portal:

Backup Instance:

ASO Logs:

asologs.txt asologs1.txt

Backup Instance YAML in Cluster:

[mayankagg9722]

@theunrepentantgeek @super-harsh Please help me to debug this further.

[matthchr]

We'll take a look at this

[mayankagg9722]

I have discussed this with @super-harsh and he figured out that this commit by him caused this breaking change: https://github.com/Azure/azure-service-operator/pull/3953/files.

We need to revert this checkin.

[matthchr]

It sounds like @super-harsh and @mayankagg9722 synced up and figured out what the issue was, and Mayank will send a PR to help resolve it.

[theunrepentantgeek]

We need to revert this checkin.

It's not as simple at this. We need to fix the regression, while keeping the quality-of-life improvements @super-harsh brought in. We also need to ascertain why the existing test suite didn't catch this problem.