azure-service-operator icon indicating copy to clipboard operation
azure-service-operator copied to clipboard

Ignore volatile properties when deciding whether to reconcile a resource

Open theunrepentantgeek opened this issue 3 years ago • 8 comments
trafficstars

We're planning on comparing the resource-as-defined with the resouce-as-read-from-ARM and doing a reconciliation between the two (First steps towards this are PR #2022 and Issue #1491).

As already discussed, we're expecting some false positives due to properties that are service defined and likely to change regularly.

We should look to use the proposed x-ms-volatile property from the Swagger specs to eliminate these properties from consideration.

x-ms-volatile Mark if a property is a system metric or prone to changes without user interaction Examples of applicable properties o nodeUpTimeInSeconds o lastAccessedTime o quotaNextResetTime

theunrepentantgeek avatar Jan 10 '22 02:01 theunrepentantgeek

Related to #1491

matthchr avatar Jan 10 '22 21:01 matthchr

Until we have #1491 we don't actually have to do this, so makes sense to defer this until #1491.

matthchr avatar Jul 11 '22 23:07 matthchr

No change on the above comment

matthchr avatar Jan 31 '23 00:01 matthchr

Ideally, a solution to this would also allow us to support #2938 - the only difference is the source of the request to ignore the property.

theunrepentantgeek avatar Jun 05 '23 23:06 theunrepentantgeek

This ties in with diffing, but is not currently needed so not worrying about this quite yet.

matthchr avatar Nov 07 '23 00:11 matthchr