azure-service-operator icon indicating copy to clipboard operation
azure-service-operator copied to clipboard

Not all resources implement ResourceBase

Open matthchr opened this issue 4 years ago • 2 comments
trafficstars

Describe the current behavior The resource manager schema implies that all resources implement resourceBase, which has tags and a few other properties. This is not correct though, there are multiple "kinds" of ARM resources and some of the (Proxy) don't have to support tags. See this for details.

Describe the improvement The Swagger specifications seem to correctly encode this information, see for example the ASK AgentPool resource which doesn't support tags according to Swagger, but which incorrectly is marked as supporting tags according to the resource manager schema JSON document.

We should stop forcing all types to inherit these ResourceBase properties, as not all of them do.

matthchr avatar Aug 19 '21 21:08 matthchr

See https://github.com/Azure/azure-resource-manager-schemas/issues/1850

matthchr avatar Aug 19 '21 21:08 matthchr

This is fixed by #2084, probably we can close this

matthchr avatar Mar 07 '22 19:03 matthchr

Verified as fixed in #2323

theunrepentantgeek avatar Nov 16 '22 01:11 theunrepentantgeek