azure-service-operator icon indicating copy to clipboard operation
azure-service-operator copied to clipboard

Need to handle additionalProperties in JSON serialization

Open Porges opened this issue 5 years ago • 8 comments
trafficstars

When serializing an ObjectType that has an additionalProperties field to JSON, we need to flatten the properties inside it into the “parent” type. I’m not sure this is even possible with the built-in JSON Go serialization library, so we might need to look elsewhere.

Porges avatar Jul 22 '20 23:07 Porges

Where does this come up?

matthchr avatar Mar 08 '22 00:03 matthchr

Where does this come up?

Mostly services that have a “map but with some well-known entries” pattern.

Porges avatar Apr 28 '22 01:04 Porges

We're still interested in doing this.

super-harsh avatar Aug 29 '22 22:08 super-harsh

Have we actually already done this? We should double-check

matthchr avatar Feb 28 '23 00:02 matthchr

We haven't done this, but would be good to do.

theunrepentantgeek avatar Jun 12 '23 23:06 theunrepentantgeek

No change from above

matthchr avatar Oct 02 '23 22:10 matthchr

Mostly services that have a “map but with some well-known entries” pattern.

Wondering if there's a way to know which services these are? Maybe we should take a look and get an understanding of how large the problem is to understand how important this is to fix?

matthchr avatar Mar 18 '24 23:03 matthchr