azure-sdk-for-ruby icon indicating copy to clipboard operation
azure-sdk-for-ruby copied to clipboard

Need to figure out how to make full code updates from swagger_to_sdk to sdk generation

Open veronicagg opened this issue 8 years ago • 4 comments

Currently swagger_to_sdk will run autorest and generate code based on PRs meged on the azure-rest-api-specs repo, since we added profiles to our sdks, the profile generation may be out of sync with the new code generation of the inner sdk bits. We need to smooth out the process, to make sure we can merge automatic PRs without problems.

veronicagg avatar Nov 01 '17 18:11 veronicagg

I talked to @lmazuel about this, swagger_to_sdk tool does not currently enable running additional commands, but he may add a feature to get that working, which would help us here. Currently he has a similar issue in python SDK and is checking out the branch from the automatic PR being created and editing it to include running the additional commands, like profile client generation.

veronicagg avatar Nov 15 '17 01:11 veronicagg

Was thinking about this this night, probably suggest a "after_generation" and "before_generation" node in the config file, where I just execute that, pushing as command line some info (package name, output folder, etc.). Thoughts?

lmazuel avatar Nov 15 '17 16:11 lmazuel

@lmazuel yes, sounds good, enabling running commands before and after should do it (we may need to add commands that install stuff for our specific tasks to run).

veronicagg avatar Nov 15 '17 18:11 veronicagg

@veronicagg done https://github.com/lmazuel/swagger-to-sdk/pull/22

Comments are welcomed :)

lmazuel avatar Nov 17 '17 00:11 lmazuel

Thank you for your interest in Azure SDKs. As detailed in this retirement announcement, this repo is no longer supported as of December 31st 2021. Please find the up-to-date list of languages and services supported with Azure SDKs here: https://aka.ms/azsdk

kurtzeborn avatar Jan 11 '23 03:01 kurtzeborn