azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

Add `tracer_provider` kwarg to `AzureMonitorTraceExporter`

Open avramdj opened this issue 1 year ago • 4 comments

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • [X] The pull request does not introduce [breaking changes]
  • [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [X] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [X] Title of the pull request is clear and informative.
  • [X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

avramdj avatar Jul 04 '24 17:07 avramdj

Thank you for your contribution @avramdj! We will review the pull request and get back to you soon.

github-actions[bot] avatar Jul 04 '24 17:07 github-actions[bot]

https://github.com/Azure/azure-sdk-for-python/issues/36362

avramdj avatar Jul 04 '24 17:07 avramdj

@avramdj

Thanks for the contribution! Please add a CHANGELOG entry and add a test for this to show that a custom TracerProvider can be used.

lzchen avatar Jul 05 '24 18:07 lzchen

Hi @avramdj - just wanted to check in as to whether you wanted to keep working on this PR? Otherwise @lzchen do you want to finish up this PR?

annatisch avatar Aug 29 '24 20:08 annatisch

@microsoft-github-policy-service agree

avramdj avatar Sep 04 '24 14:09 avramdj

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-monitor-opentelemetry-exporter

azure-sdk avatar Sep 04 '24 16:09 azure-sdk