azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

[ml] Revert Exception to MlException change in activity.py

Open diondrapeck opened this issue 9 months ago • 1 comments

Description

In #35342, replacing Exception with MlException to appease the next-pylint restriction on using the BaseException class caused unittest failures for azureml-featurestore due to differences in the message attributes for the two classes. In this PR, I am reverting to the use of Exception and simply silencing the pylint error on that line.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

diondrapeck avatar May 02 '24 20:05 diondrapeck

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

azure-sdk avatar May 02 '24 21:05 azure-sdk