azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

Generate and implement Face SDK via TypeSpec

Open zihyunting opened this issue 1 year ago • 3 comments

Description

This PR contains:

  • Face SDK is generated by https://github.com/Azure/azure-rest-api-specs/pull/27576.
  • Samples
  • Tests

ToDo:

  • SDK Readme, It will be filled in in the upstream branch: https://github.com/azure-sdk/azure-sdk-for-python/pull/6365.

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

zihyunting avatar Apr 26 '24 17:04 zihyunting

Thank you for your contribution @zihyunting! We will review the pull request and get back to you soon.

github-actions[bot] avatar Apr 26 '24 17:04 github-actions[bot]

/azp run prepare-pipelines

kristapratico avatar May 01 '24 17:05 kristapratico

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 01 '24 17:05 azure-pipelines[bot]

/azp run prepare-pipelines

zihyunting avatar May 03 '24 14:05 zihyunting

Commenter does not have sufficient privileges for PR 35384 in repo Azure/azure-sdk-for-python

azure-pipelines[bot] avatar May 03 '24 14:05 azure-pipelines[bot]

/azp run python - face - ci

CI is running here: https://dev.azure.com/azure-sdk/public/_build/results?buildId=3759218&view=results

kristapratico avatar May 03 '24 22:05 kristapratico

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-vision-face

azure-sdk avatar May 06 '24 11:05 azure-sdk

@zihyunting Please make sure CI passed for all these items: image nit: The Details link contain detailed log info and you can fix with those info

msyyc avatar May 09 '24 03:05 msyyc