azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

Azure Programmable Connectivity SDK initial

Open aronhegedusms opened this issue 2 years ago • 12 comments

Description

This is a PR to add python SDK for Azure Programmable Connectivity.

Typespec can be seen here: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/programmableconnectivity/Azure.ProgrammableConnectivity/tspconfig.yaml

Tests have been added, and migrated to Azure/azure-sdk-assets

All SDK Contribution checklist:

  • [X] The pull request does not introduce [breaking changes]
  • [X] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [X] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [X] Title of the pull request is clear and informative.
  • [X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

aronhegedusms avatar Mar 15 '24 16:03 aronhegedusms

Our team (Azure Programmable Connectivity) is still working on a small typespec change, after which this PR will be ready to go in.

aronhegedusms avatar Mar 15 '24 16:03 aronhegedusms

Our team (Azure Programmable Connectivity) is still working on a small typespec change, after which this PR will be ready to go in.

https://github.com/Azure/azure-rest-api-specs/pull/28080

This typespec PR will go in as soon as a pipeline issue gets fixed. Until then, we'd appreciate comments/review on this PR. It's the first time our team has done a PR into Azure/azure-sdk-for-python, so apologies if we have forgotten something.

But samples have been written, README.md updated, changelog added, tests added, with recordings migrated, tests passing

aronhegedusms avatar Mar 21 '24 11:03 aronhegedusms

/azp run prepare-pipelines

kristapratico avatar Mar 25 '24 16:03 kristapratico

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 25 '24 16:03 azure-pipelines[bot]

It would be nice to add some samples under a samples/ directory before the first beta.

I will add the samples that I have into the samples/ folder, and remove them from the README.md, and just link to them

aronhegedusms avatar Mar 27 '24 17:03 aronhegedusms

/azp run python - programmableconnectivity - ci

kristapratico avatar Mar 28 '24 17:03 kristapratico

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Mar 28 '24 17:03 azure-pipelines[bot]

/azp run python - programmableconnectivity - ci

kristapratico avatar Mar 28 '24 17:03 kristapratico

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 28 '24 17:03 azure-pipelines[bot]

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-programmableconnectivity

azure-sdk avatar Apr 09 '24 18:04 azure-sdk

@xiangyan99 I have written some async tests as well now. I've noticed quite a lot of repetition between the README.md/test code/async test code. In the .NET SDK they mandate the use of snippets, but I've not seen this as much in the python repository.

Can you confirm that it's OK to have copy/pasted code?

aronhegedusms avatar Apr 15 '24 16:04 aronhegedusms

@xiangyan99 I have written some async tests as well now. I've noticed quite a lot of repetition between the README.md/test code/async test code. In the .NET SDK they mandate the use of snippets, but I've not seen this as much in the python repository.

Can you confirm that it's OK to have copy/pasted code?

Do you mean https://github.com/Azure/azure-sdk-for-python/blob/main/doc/dev/code_snippets.md?

We support referencing snippets in README. But not mandate it. :)

xiangyan99 avatar Apr 15 '24 16:04 xiangyan99

Hi @aronhegedusms. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

github-actions[bot] avatar Jul 12 '24 05:07 github-actions[bot]

Hi @aronhegedusms. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

github-actions[bot] avatar Jul 19 '24 08:07 github-actions[bot]