azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Pre-GA SDK for Azure LoadTesting

Open NiveditJain opened this issue 2 years ago • 4 comments

Description

pre-ga SDK release for Azure LoadTesting

Checklist

  • [x] Started PR
  • [x] Completed Directives
  • [x] Completed Generations
  • [x] Custom Changes Done (including LRO Changes)
  • [x] API View Done
  • [x] Documentations Updated
  • [x] Samples Updated
  • [x] Changelog Updated
  • [x] Swagger Link Changed to main Repo
  • [x] Added Tests and Make Necessary Updates
  • [x] Pipelines Fixed

NiveditJain avatar Nov 03 '22 08:11 NiveditJain

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-developer-loadtesting

azure-sdk avatar Nov 03 '22 08:11 azure-sdk

API View at: https://apiview.dev/Assemblies/Review/fc0755250d5e4c59b4b0a9e4d20dee53

NiveditJain avatar Nov 03 '22 10:11 NiveditJain

@NiveditJain I notice that you rename many operation. Could you run live test and commit your recording files?

msyyc avatar Nov 21 '22 03:11 msyyc

@NiveditJain I notice that you rename many operation. Could you run live test and commit your recording files?

@msyyc I have added tests!

NiveditJain avatar Dec 28 '22 08:12 NiveditJain

Hi @NiveditJain The PR overall looks good. I notice that there is empty file _polling.py which I think shall be removed.

msyyc avatar Jan 06 '23 01:01 msyyc

Hi @NiveditJain The PR overall looks good. I notice that there is empty file _polling.py which I think shall be removed.

Hi @msyyc I have removed the file, can you please mark this PR as approved if there are no other comments?

NiveditJain avatar Jan 06 '23 05:01 NiveditJain