azure-sdk-for-python
azure-sdk-for-python copied to clipboard
Azure
[Storage] Improve error code for `PublicAccessNotPermitted`
This PR is for a change to how PublicAccessNotPermitted is raised. Currently, from generated it is a ResourceExistsError, and so it will surface that (and PublicAccessNotPermitted is only known from the XML deserialization).
This PR checks for this special case, and if encountered forces it to be serialized as if it was not serialized from generated, thus allowing it to surface the correct error (auth error). An alternative approach is to make an adjustment at the _generated layer.
Resolves #26919
API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-blob azure-storage-file-share azure-storage-file-datalake azure-storage-queue
Hi @vincenttran-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.
Hi @vincenttran-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.