azure-sdk-for-python
azure-sdk-for-python copied to clipboard
[batch] fix: typo in batch/azure-batch
Description
fix https://github.com/Azure/azure-sdk-for-python/issues/22593
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
- [x] The pull request does not introduce [breaking changes]
- [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
- [x] I have read the contribution guidelines.
General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
Thank you for your contribution KdHyeon0661! We will review the pull request and get back to you soon.
The pipeline failures are coming from this minimum dependency conflict:
The conflict is caused by: The user requested msrest==0.6.21 azure-mgmt-batch 16.2.0 depends on msrest>=0.7.1
To fix this, we can either place an upper bound on the azure-mgmt-batch
requested in azure-batch/dev_requirements.txt, to a version of the package that only requires msrest>=0.6.21
. Or, we could bump the required version of msrest
in azure-batch
's setup.py
.
@cRui861, @dpwatrous, @paterasMSFT, @gingi, @zfengms: do you have any thoughts? My personal recommendation would be to just bump azure-batch
's required version since it should be backwards-compatible regardless. But without the package owners' input, updating the azure-mgmt-batch
dev requirement for now is a safer option to get this PR merged.
Hi @KdHyeon0661. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.
Hi @KdHyeon0661. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.