azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

refactor:eventhub/_eventprocessor:type hint added

Open JJHWAN opened this issue 1 year ago • 2 comments

Description

issue #25471

Changed \eventhub\azure-eventhub\azure\eventhub_eventprocessor directory with type hints

Will work with other dir too, later :)

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

JJHWAN avatar Sep 14 '22 10:09 JJHWAN

Thank you for your contribution JJHWAN! We will review the pull request and get back to you soon.

ghost avatar Sep 14 '22 10:09 ghost

@swathipil applied your reviews!

JJHWAN avatar Sep 25 '22 03:09 JJHWAN

Hi @JJHWAN. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

ghost avatar Dec 02 '22 10:12 ghost

Hi @JJHWAN. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

ghost avatar Dec 09 '22 17:12 ghost

/reopen

swathipil avatar Dec 09 '22 21:12 swathipil

/azp run python - eventhub - tests

swathipil avatar Dec 12 '22 18:12 swathipil

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 12 '22 18:12 azure-pipelines[bot]

/azp run python - eventhub - tests

swathipil avatar Dec 13 '22 18:12 swathipil

/azp run python - eventhub - tests

swathipil avatar Dec 13 '22 18:12 swathipil

/azp run python - eventhub - ci

swathipil avatar Dec 13 '22 18:12 swathipil

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 13 '22 18:12 azure-pipelines[bot]

/azp run python - eventhub - tests

swathipil avatar Dec 13 '22 18:12 swathipil