azure-sdk-for-python
azure-sdk-for-python copied to clipboard
[keyvault] Remove Python 3.6 and six references
Description
Dear @mccoyp, after review we found some changes were lost during updates. Thank you.
Is your feature request related to a problem? Please describe.
In accordance with the August Milestone of Azure for dropping Python 3.6 support, changes that were made to the keyvault packages have been recovered. We also recovered @ponopono0322's contribution of removing references to the six
package.
Describe the solution you'd like
Drop Python 3.6 support and add 3.10 to the supported versions list.
Remove all references of six
package from keyvault code.
Describe alternatives you've considered None
Additional context https://github.com/Azure/azure-sdk-for-python/pull/25449 https://github.com/Azure/azure-sdk-for-python/pull/25902
All SDK Contribution checklist:
- [x] The pull request does not introduce [breaking changes]
- [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
- [x] I have read the contribution guidelines.
General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon.
By the way -- I'm currently regenerating our generated code, and that will drop the implicit six
dependency and should get CI passing on this PR. I'll merge the regeneration work soon and then we can merge this right after 🙂
Hi again @wonhyeongseo, I'm back! The code regeneration I mentioned earlier just went through today: https://github.com/Azure/azure-sdk-for-python/pull/27170
If you update this PR with main
, this PR should be just about ready to go. There are a number of merge conflicts since this has been up for a while though (which is because of us -- my apologies), so it may be easier to open a separate PR with these changes.
One last note: the azure-mgmt-keyvault
package is owned by a different set of folks than the azure-keyvault-*
packages, so it would be best to leave azure-mgmt-keyvault
changes for a separate PR. You can tag me if you'd like to open one, and I would make sure the package owners see it!
Thank you again for the contribution and for your patience!
Closing in favor of #27377